Re: Issue 323 in msysgit: Can't clone over http
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 9, 2009, 19:08 UTC
- Message-ID
- <7vljkoszqf.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20090909203350.e3d7e5dc.rctay89@gmail.com>
Tay Ray Chuan <rctay89@gmail.com> writes:
Show 28 quoted lines
> I still think github.com should look into this issue (of differing
> responses for HEAD and GET requests).
>
> -- >8 --
>
> Subject: [PATCH] http.c: remove verification of remote packs
>
> Make http.c::fetch_pack_index() no longer check for the remote pack
> with a HEAD request before fetching the corresponding pack index file.
>
> Not only does sending a HEAD request before we do a GET incur a
> performance penalty, it does not offer any significant error-
> prevention advantages (pack fetching in the *_http_pack_request()
> methods is capable of handling any errors on its own).
>
> This addresses an issue raised elsewhere:
>
> http://code.google.com/p/msysgit/issues/detail?id=323
> http://support.github.com/discussions/repos/957-cant-clone-over-http-or-git
>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
> ---
>
> Junio, I'm not sure if the credits and references ("This addresses...")
> should be included, since the patch doesn't look like it's fixing any
> thing, even though it is a response to an acknowledged issue.
>
> Please remove those lines if you so wish.I think the backstory deserves to be recorded in this case, which is what you did.
Thanks.