Re: git-grep: option parsing conflicts with prefix-dash searches

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 8, 2010, 01:06 UTC
Message-ID: <7vljf41qoq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100207044415.GA6622@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Here it is with a commit message and some tests. While it is a minor
> change, we are pretty late in the release cycle, so perhaps it is best
> to leave it post-1.7.0 just to be on the safe side.

Your explanation that "-- marks the end of options" makes perfect sense and it is not inconsistent with what we do either. "grep" is an oddball that among its non-option arguments the first one _can_ be a non-path (namely, the single pattern you are looking for), but with your patch, that logic is nicely expressed, too.

I am tempted to push it into 1.7.0 but I'd keep it in 'next' for now.

Thanks.