Re: [PATCH 1/4] convert: Safer handling of $Id$ contraction.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 3, 2010, 01:10 UTC
- Message-ID
- <7vljeamcpq.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1267460218-1172-1-git-send-email-grubba@grubba.org>
Henrik Grubbström <grubba@grubba.org> writes:
> From: Henrik Grubbström (Grubba) <grubba@grubba.org>
You can omit this line, as it is the same as your From: header.
> The code to contract $Id:xxxxx$ strings could eat an arbitrary amount > of source text if the terminating $ was lost. It now refuses to > contract $Id:xxxxx$ strings spanning multiple lines.
Hmm, at least when going from working tree to the index, shouldn't the code refuse _and_ die(), instead of silently pass the garbage through?