Re: [PATCH] checkout: respect diff.ignoreSubmodules setting

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 25, 2010, 20:10 UTC
Message-ID: <7vlj7uqwr6.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4C755778.7010306@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

Show 10 quoted lines

> Am 25.08.2010 12:34, schrieb Johannes Schindelin:
>>  ...
>> Let's respect that setting when 'git checkout' reports the uncommitted
>> changes, since it does nothing else than a 'git diff --name-status'.
>> 
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Thanks for fixing that!
>
> Acked-by: Jens Lehmann <Jens.Lehmann@web.de>

Makes sense.

I wondered if the new parameter to show_local_changes() should just be of type (struct checkout_opts *), so that other options given to checkout, not necessarily related to the diff generation, can influence the output further if we wanted to, but that kind of change can be done if and when it becomes necessary.

Thanks.  Perhaps we would want a new test or two in t2013?