Re: [PATCH] shell: Display errors from improperly-formatted command lines

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 27, 2010, 17:28 UTC
Message-ID: <7vlj7shsn5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1282887373-25618-1-git-send-email-gdb@mit.edu>

Greg Brockman <gdb@MIT.EDU> writes:

Show 6 quoted lines

> The interface for split_cmdline has changed such that the caller holds
> responsibility for printing any error messages.  This patch changes
> the git shell to print these error messages as appropriate.
> ---
>  shell.c |   16 +++++++++++++---
>  1 files changed, 13 insertions(+), 3 deletions(-)

Forgot to sign-off?

> The error behavior of split_cmdline was changed in the patch  'split_cmdline: Allow
> caller to access error string'.  This updates git-shell to deal with printing out
> split_cmdline errors itself.

Thanks for being careful. I'll merge gb/split-cmdline-errmsg topic (which already is in master) to gb/shell-ext topic (which is cooking in next) and then apply this on top. With this update I suppose the topic is ready to be in the next release?