git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] completion: complete "git diff ...branc<TAB>"

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 23, 2011, 21:43 UTC
Message-ID
<7vlj1677gz.fsf@alter.siamese.dyndns.org>

While doing a final sanity check before merging a topic Bsomething, it is a good idea to review what damage Bsomething branch would make, by running:

    $ git diff ...Bsomething

I however find myself often typing "git diff ...B<TAB>", seeing nothing happening and then repeatedly hitting <TAB>, saying "huh? <TAAAAAAAAB>!".

This change would hopefully help me, and others like me.

Even though there is no point in supporting "git diff A..B" (you can say "git diff A B" just fine), but reusing complete-revlist was the easiest and that form is supported as a benign but not so useful side effect.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 * I sent this out a while ago and have been using it ever since, but
   totally forgot about it.  Likes, dislikes, alternatives?
 contrib/completion/git-completion.bash |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 64341d5..cf56514 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1137,7 +1137,7 @@ _git_diff ()
 		return
 		;;
 	esac
-	__git_complete_file
+	__git_complete_revlist
 }
 
 __git_mergetools_common="diffuse ecmerge emerge kdiff3 meld opendiff
Next: Michael J Gruber
Message 1 of 9 in “completion: complete "git diff ...branc<TAB>"”
  1. completion: complete "git diff ...branc<TAB>"Junio C Hamano, Feb 23, 2011
  2. Michael J GruberFeb 24, 2011
  3. SZEDER GáborFeb 24, 2011
  4. Michael J GruberFeb 24, 2011
  5. SZEDER GáborFeb 24, 2011
  6. Junio C HamanoFeb 24, 2011
  7. 1/2 bash: fix misindented esac statement in __git_complete_file()SZEDER Gábor, Mar 10, 2011
  8. 2/2 bash: complete 'git diff ...branc<TAB>'SZEDER Gábor, Mar 10, 2011
  9. Junio C HamanoMar 10, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.