git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 04/19] Disallow the empty string as an attribute name

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 27, 2011, 20:20 UTC
Message-ID
<7vlivjo479.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1311689582-3116-5-git-send-email-mhagger@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
> Previously, it was possible to have a line like "file.txt =foo" in a
> .gitattribute file, after which an invocation like "git check-attr ''
> -- file.txt" would succeed.  This patch disallows both constructs.
Good. Very much appreciated.
> Currently it is possible to use the empty string as an attribute name.
Yeah, even I wouldn't call it a regression to disallow this ;-).
Previous: Michael HaggertyNext: Michael Haggerty
Message 6 of 24 in “Add --all option to git-check-attr”
  1. 00/19 Add --all option to git-check-attrMichael Haggerty, Jul 26, 2011
  2. 01/19 doc: Add a link from gitattributes(5) to git-check-attr(1)Michael Haggerty, Jul 26, 2011
  3. 02/19 doc: Correct git_attr() calls in example codeMichael Haggerty, Jul 26, 2011
  4. 03/19 Remove anachronism from commentMichael Haggerty, Jul 26, 2011
  5. 04/19 Disallow the empty string as an attribute nameMichael Haggerty, Jul 26, 2011
  6. Junio C HamanoJul 27, 2011
  7. 05/19 git-check-attr: Add missing "&&"Michael Haggerty, Jul 26, 2011
  8. 06/19 git-check-attr: Add tests of command-line parsingMichael Haggerty, Jul 26, 2011
  9. 07/19 Provide access to the name attribute of git_attrMichael Haggerty, Jul 26, 2011
  10. Junio C HamanoJul 27, 2011
  11. Michael HaggertyJul 28, 2011
  12. 08/19 git-check-attr: Use git_attr_name()Michael Haggerty, Jul 26, 2011
  13. 09/19 Allow querying all attributes on a fileMichael Haggerty, Jul 26, 2011
  14. 10/19 git-check-attr: Extract a function output_attr()Michael Haggerty, Jul 26, 2011
  15. 11/19 git-check-attr: Introduce a new variableMichael Haggerty, Jul 26, 2011
  16. 12/19 git-check-attr: Extract a function error_with_usage()Michael Haggerty, Jul 26, 2011
  17. 13/19 git-check-attr: Handle each error separatelyMichael Haggerty, Jul 26, 2011
  18. 14/19 git-check-attr: Process command-line args more systematicallyMichael Haggerty, Jul 26, 2011
  19. 15/19 git-check-attr: Error out if no pathnames are specifiedMichael Haggerty, Jul 26, 2011
  20. 16/19 git-check-attr: Add an --all option to show all attributesMichael Haggerty, Jul 26, 2011
  21. Michael HaggertyJul 28, 2011
  22. 17/19 git-check-attr: Drive two tests using the same raw dataMichael Haggerty, Jul 26, 2011
  23. 18/19 git-check-attr: Fix command-line handling to match docsMichael Haggerty, Jul 26, 2011
  24. 19/19 Rename struct git_attr_check to git_attr_valueMichael Haggerty, Jul 26, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.