git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH na/strtoimax] Compatibility: declare strtoimax() under NO_STRTOUMAX

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 6, 2011, 06:10 UTC
Message-ID
<7vlirt7pdk.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4EB5583E.2030306@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 5 quoted lines
> Commit f696543d (Add strtoimax() compatibility function) introduced an
> implementation of the function, but forgot to add a declaration.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---

Thanks, but I think f696543d is v1.7.6 and not that patch. I hope you do not mind if I just squashed this in, instead of leaving it as a separate patch.

Show 16 quoted lines
>  git-compat-util.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/git-compat-util.h b/git-compat-util.h
> index feb6f8e..4efef46 100644
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -354,6 +354,8 @@ extern size_t gitstrlcpy(char *, const char *, size_t);
>  #ifdef NO_STRTOUMAX
>  #define strtoumax gitstrtoumax
>  extern uintmax_t gitstrtoumax(const char *, char **, int);
> +#define strtoimax gitstrtoimax
> +extern intmax_t gitstrtoimax(const char *, char **, int);
>  #endif
>  
>  #ifdef NO_STRTOK_R
Previous: Ramsay JonesNext: Johannes Sixt
Message 5 of 6 in “Compatibility: declare strtoimax() under NO_STRTOUMAX”
  1. Compatibility: declare strtoimax() under NO_STRTOUMAXJohannes Sixt, Nov 5, 2011
  2. NixNov 5, 2011
  3. Johannes SixtNov 5, 2011
  4. Ramsay JonesNov 6, 2011
  5. Junio C HamanoNov 6, 2011
  6. Johannes SixtNov 6, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.