git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Sending patches with KMail (Re: [PATCH] git-blame.el: Fix compilation warnings.)

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 14, 2012, 00:59 UTC
Message-ID
<7vlipbxfne.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120113233158.GD7343@burratino>
Jonathan Nieder <jrnieder@gmail.com> writes:
> The hints at [1] might also be useful, in case you would like to try
> and consider improving the manpage to document them if they work.
Don't you need similar updates to sections for other MUAs and procedures?

I suspect that the reason why you added the new text there is because you know KMail users are very lazy bunch, and once they see a "KMail" subsection, they will skip everything outside the subsection. Thunderbird users would also be lazy---after choosing one of the three approaches presented, they will skip anything outside the subsubsection. So I can understand that we would need something in these individual subsections, but the advice does not logically belong there.

Perhaps rephrasing the early part of the Discussion section, with an illustration that is designed to be more visible, would be a better approach?

For example, we could take your log message and stuff it there:
    The opening "From " line and following lines in "git format-patch" are
    for your mailer and should be omitted except for fields that differ from
    the mail header when reading your patch into an email body. For example,
    the output of your format-patch may begin like this:
          From 13c41b41b832d41680ccd33a2422ef8217965566 Mon Sep 17 00:00:00 2001
          From: Jonathan Nieder <jrnieder@gmail.com>
          Date: Fri, 13 Jan 2012 17:22:41 -0600
          Subject: Documentation/format-patch: mention removal of in-body headers
          The opening "From " line and following lines in ...
    The part you should send in the body of your e-mail message begins at the
    first blank line. The "From $SHA1 $magic_timestamp" line and other header
    lines are there to make it look like a mbox, and if you send it in e-mail,
    they will become redundant.
    You can leave "From:" and/or "Subject:" lines in, if they are
    different from the e-mail you will be sending out (e.g. you are
    forwarding a patch written by somebody else, as a follow up to an
    ongoing discussion and do not want the subject of your e-mail message
    to help threading).  E.g. your message _may_ begin like this:
          From: Jonathan Nieder <jrnieder@gmail.com>
          Subject: Documentation/format-patch: mention removal of in-body headers
          The opening "From " line and following lines in ...
    when you are not Jonathan, and you are sending it as a response to
    an existing discussion thread.
Or something like that?
Previous: Jonathan NiederNext: Jonathan Nieder
Message 5 of 18 in “git-blame.el: Fix compilation warnings.”
  1. git-blame.el: Fix compilation warnings.Rüdiger Sonderfeld, Jan 12, 2012
  2. Jonathan NiederJan 12, 2012
  3. Rüdiger SonderfeldJan 12, 2012
  4. Sending patches with KMail (Re: [PATCH] git-blame.el: Fix compilation warnings.)Jonathan Nieder, Jan 13, 2012
  5. Junio C HamanoJan 14, 2012
  6. Jonathan NiederJan 14, 2012
  7. Jonathan NiederJan 14, 2012
  8. Junio C HamanoJan 15, 2012
  9. Rüdiger SonderfeldJan 14, 2012
  10. git-blame.el: use mapc instead of mapcarJonathan Nieder, Jun 10, 2012
  11. 1/3 git-blame.el: Do not use goto-line in lisp codeLawrence Mitchell, Jun 10, 2012
  12. 2/3 git-blame.el: Use with-current-buffer where appropriateLawrence Mitchell, Jun 10, 2012
  13. 3/3 git-blame.el: Do not use bare 0 to mean (point-min)Lawrence Mitchell, Jun 10, 2012
  14. Jonathan NiederJun 14, 2012
  15. Lawrence MitchellJun 14, 2012
  16. 1/3 git-blame.el: Do not use goto-line in lisp codeLawrence Mitchell, Jun 14, 2012
  17. 2/3 git-blame.el: Use with-current-buffer where appropriateLawrence Mitchell, Jun 14, 2012
  18. 3/3 git-blame.el: Do not use bare 0 to mean (point-min)Lawrence Mitchell, Jun 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.