Re: [PATCH 1/3] add mergesort() for linked lists

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 11, 2012, 16:44 UTC
Message-ID: <7vlim2md4r.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F85226A.7050709@gmail.com>

Stephen Boyd <bebarino@gmail.com> writes:

Show 27 quoted lines

> On 03/31/2012 03:10 PM, René Scharfe wrote:
>> diff --git a/mergesort.c b/mergesort.c
>> new file mode 100644
>> index 0000000..c0f1874
>> --- /dev/null
>> +++ b/mergesort.c
>> @@ -0,0 +1,75 @@
>> +#include "cache.h"
>> +#include "mergesort.h"
>> +
>> +#include "commit.h"
>
> This is an unnecessary include, right?
>
> diff --git a/mergesort.c b/mergesort.c
> index c0f1874..d084c60 100644
> --- a/mergesort.c
> +++ b/mergesort.c
> @@ -1,8 +1,6 @@
>  #include "cache.h"
>  #include "mergesort.h"
>
> -#include "commit.h"
> -
>  struct mergesort_sublist {
>         void *ptr;
>         unsigned long len;

Yes. I'll squash in, as I tentatively kicked many topics out of 'next' and this was among them.