git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Document MKDIR_WO_TRAILING_SLASH in Makefile

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 7, 2012, 17:29 UTC
Message-ID
<7vliglyc5g.fsf@alter.siamese.dyndns.org>
In-Reply-To
<003301cd8cf1$d26258c0$77270a40$@schmitz-digital.de>
"Joachim Schmitz" <jojo@schmitz-digital.de> writes:
Show 18 quoted lines
> Signed-off-by: Joachim Schmitz <jojo@schmitz-digital.de>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index ac49320..03e245a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -90,6 +90,8 @@ all::
>  #
>  # Define NO_MKDTEMP if you don't have mkdtemp in the C library.
>  #
> +# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
> +#
>  # Define NO_MKSTEMPS if you don't have mkstemps in the C library.
>  #
>  # Define NO_STRTOK_R if you don't have strtok_r in the C library.

Not really. "make MKDIR_WO_TRAILING_SLASH=YesPlease" won't do anything.

You would need at least something like this, no?
 Makefile | 5 +++++
 1 file changed, 5 insertions(+)
diff --git c/Makefile w/Makefile
index 66e8216..21b4816 100644
--- c/Makefile
+++ w/Makefile
@@ -90,6 +90,8 @@ all::
 #
 # Define NO_MKDTEMP if you don't have mkdtemp in the C library.
 #
+# Define MKDIR_WO_TRAILING_SLASH if your mkdir() can't deal with trailing slash.
+#
 # Define NO_MKSTEMPS if you don't have mkstemps in the C library.
 #
 # Define NO_STRTOK_R if you don't have strtok_r in the C library.
@@ -1639,6 +1641,9 @@ ifdef NO_MKDTEMP
 	COMPAT_CFLAGS += -DNO_MKDTEMP
 	COMPAT_OBJS += compat/mkdtemp.o
 endif
+ifdef MKDIR_WO_TRAILING_SLASH
+	COMPAT_CFLAGS += -DMKDIR_WO_TRAILING_SLASH
+endif
 ifdef NO_MKSTEMPS
 	COMPAT_CFLAGS += -DNO_MKSTEMPS
 endif
Previous: Junio C HamanoNext: Joachim Schmitz
Message 3 of 5 in “Document MKDIR_WO_TRAILING_SLASH in Makefile”
  1. Document MKDIR_WO_TRAILING_SLASH in MakefileJoachim Schmitz, Sep 7, 2012
  2. Junio C HamanoSep 7, 2012
  3. Junio C HamanoSep 7, 2012
  4. Joachim SchmitzSep 7, 2012
  5. Joachim SchmitzSep 8, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.