git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] pathspec: apply "*.c" optimization from exclude

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 20, 2012, 19:47 UTC
Message-ID
<7vlidwrr86.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CACsJy8C=vdvHYgMr8Qa7M+Mq=QO6p6dsOFm_ZW=Nf2VQrPwaMg@mail.gmail.com>
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
Show 7 quoted lines
>> When you come to strcmp(), you see that string_len is 1, pattern_len
>> is 3, and pattern is "oob".  string+string_len-pattern_len = "oob",
>> one past the beginning of the original string "foob".  They match.
>>
>> Oops?
>
> Oops indead. I'll need to check exclude code too :(

Ok, the one queued on 'pu' has been locally fixed when I sent the message you are responding to.

Previous: Nguyen Thai Ngoc DuyNext: Nguyễn Thái Ngọc Duy
Message 10 of 11 in “Some pathspec wildcard optimization”
  1. 0/4 Some pathspec wildcard optimizationNguyễn Thái Ngọc Duy, Nov 18, 2012
  2. 1/4 pathspec: save the non-wildcard length partNguyễn Thái Ngọc Duy, Nov 18, 2012
  3. Junio C HamanoNov 19, 2012
  4. 2/4 pathspec: do exact comparison on the leading non-wildcard partNguyễn Thái Ngọc Duy, Nov 18, 2012
  5. Junio C HamanoNov 19, 2012
  6. Nguyen Thai Ngoc DuyNov 20, 2012
  7. 3/4 pathspec: apply "*.c" optimization from excludeNguyễn Thái Ngọc Duy, Nov 18, 2012
  8. Junio C HamanoNov 19, 2012
  9. Nguyen Thai Ngoc DuyNov 20, 2012
  10. Junio C HamanoNov 20, 2012
  11. 4/4 tree_entry_interesting: do basedir compare on wildcard patterns when possibleNguyễn Thái Ngọc Duy, Nov 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.