[PATCH] match_push_refs(): nobody sets src->peer_ref anymore
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 4, 2013, 22:36 UTC
- Message-ID
- <7vlia2x05q.fsf@alter.siamese.dyndns.org>
In ancient times, we used to disallow the same source ref to be pushed to more than one places, e.g. "git push there master:master master:naster" was disallowed. We later lifted this restriction with db27ee63929f (send-pack: allow the same source to be pushed more than once., 2005-08-06) and there no longer is anybody that sets peer_ref for the source side of the ref list in the push codepath since then.
Remove one leftover no-op in a loop that iterates over the source side of ref list (i.e. our local ref) to see if it can/should be sent to a matching destination ref while skipping ones that is marked with peer_ref (which will never exist, so we do not skip anything).
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- remote.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/remote.c b/remote.c index e53a6eb..bac2b02 100644 --- a/remote.c +++ b/remote.c @@ -1227,9 +1227,6 @@ int match_push_refs(struct ref *src, struct ref **dst, const struct refspec *pat = NULL; char *dst_name; - if (ref->peer_ref) - continue; - dst_name = get_ref_match(rs, nr_refspec, ref, send_mirror, FROM_SRC, &pat); if (!dst_name) continue;
-- 1.8.2-rc2-182-g857a7fa