git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH jk/checkout-attribute-lookup] t2003: work around path mangling issue on Windows

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 20, 2013, 17:10 UTC
Message-ID
<7vli9if159.fsf@alter.siamese.dyndns.org>
In-Reply-To
<514977BD.6060604@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
Show 5 quoted lines
> From: Johannes Sixt <j6t@kdbg.org>
>
> MSYS bash considers the part "/g" in the sed expression "s/./=/g" as an
> absolute path after an assignment, and mangles it to a C:/something
> string. Do not attract bash's attention by avoiding the equals sign.

If this breakage is about path mangling, I suspect it may be cleaner to work it around by not using / as the pattern separator, e.g.

	sed -e s!.!=!g

Or perhaps use SHELL_PATH to point at a more reasonable implementation of shell that does not have such an idiocy?

Show 25 quoted lines
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
>  t/t2003-checkout-cache-mkdir.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t2003-checkout-cache-mkdir.sh b/t/t2003-checkout-cache-mkdir.sh
> index 4c97468..ff163cf 100755
> --- a/t/t2003-checkout-cache-mkdir.sh
> +++ b/t/t2003-checkout-cache-mkdir.sh
> @@ -94,14 +94,14 @@ test_expect_success 'apply filter from working tree .gitattributes with --prefix
>  	rm -fr path0 path1 path2 tmp* &&
>  	mkdir path1 &&
>  	mkdir tmp &&
> -	git config filter.replace-all.smudge "sed -e s/./=/g" &&
> +	git config filter.replace-all.smudge "sed -e s/./,/g" &&
>  	git config filter.replace-all.clean cat &&
>  	git config filter.replace-all.required true &&
>  	echo "file1 filter=replace-all" >path1/.gitattributes &&
>  	git checkout-index --prefix=tmp/ -f -a &&
>  	echo frotz >expected &&
>  	test_cmp expected tmp/path0 &&
> -	echo ====== >expected &&
> +	echo ,,,,,, >expected &&
>  	test_cmp expected tmp/path1/file1
>  '
Previous: Johannes SixtNext: Johannes Sixt
Message 2 of 3 in “t2003: work around path mangling issue on Windows”
  1. t2003: work around path mangling issue on WindowsJohannes Sixt, Mar 20, 2013
  2. Junio C HamanoMar 20, 2013
  3. Johannes SixtMar 21, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.