git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] t5520 (pull): use test_config where appropriate

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 28, 2013, 15:17 UTC
Message-ID
<7vli97wo3i.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7vy5d7wpbi.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 12 quoted lines
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>
>> Configuration from test_config does not last beyond the end of the
>> current test assertion, making each test easier to think about in
>> isolation.
>>
>> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
>> ---
>>  Removed first hunk, as per Junio's comment.
>
> Thanks, but doesn't yd/use-test-config-unconfig topic already
> address this?

The last hunk from your version was missing from 9d6aa64dc32b (t5520: use test_config to set/unset git config variables, 2013-03-24); I'll pick that part and apply as a follow up to the series.

No need to resend; thanks.
Previous: Ramkumar Ramachandra
Message 8 of 8 in “Fix a couple of minor things in pull test”
  1. 0/2 Fix a couple of minor things in pull testRamkumar Ramachandra, Mar 22, 2013
  2. 1/2 t5520 (pull): update test descriptionRamkumar Ramachandra, Mar 22, 2013
  3. 2/2 t5520 (pull): use test_config where appropriateRamkumar Ramachandra, Mar 22, 2013
  4. Junio C HamanoMar 25, 2013
  5. 2/2 t5520 (pull): use test_config where appropriateRamkumar Ramachandra, Mar 28, 2013
  6. Junio C HamanoMar 28, 2013
  7. Ramkumar RamachandraMar 28, 2013
  8. Junio C HamanoMar 28, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.