Re: [PATCH] remote-bzr: fixes for older versions of bzr

From: Junio C Hamano <gitster@pobox.com>
Date: May 17, 2013, 18:45 UTC
Message-ID: <7vli7dxx6v.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s0WbkaWsU+VOCsd2THEQJkTU-67_z5Kb37j=gS9U1MV2Q@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 8 quoted lines

> On Fri, May 17, 2013 at 1:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> On Fri, May 17, 2013 at 12:10 PM, Felipe Contreras
>>> <felipe.contreras@gmail.com> wrote:
>>>> Up to v2.0.
>>
>> Is that "down to v2.0"?

Is that 'down to v2.0'?

Show 14 quoted lines

>>
>>>>
>>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>>> ---
>>>>  contrib/remote-helpers/git-remote-bzr | 6 ++++--
>>>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> We want this for v1.8.3, otherwise it wouldn't work in older versions of bzr.
>>
>> I take it that somebody tested this with both new and old versions
>> so that the old way you rewrote the code with is still supported by
>> the more recent ones.
>
> Yeah. I wrote a script that tests in a bunch of versions.

Nice to know ;-)

>
> Also, I'm fiddling with travis-ci:
> https://travis-ci.org/felipec/git/builds/7258332