Re: [PATCH 4/4] Invalidate cache-tree entries for touched paths in git-apply.

From: Junio C Hamano <junkio@cox.net>
Date: Apr 24, 2006, 02:47 UTC
Message-ID: <7vk69fd70m.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7vodyrdas9.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 13 quoted lines

> Junio C Hamano <junkio@cox.net> writes:
>
>>  * ... then the big rock falls.  With this, I tried to apply and
>>    then write-tree "diff-tree -p $commit^1 $commit" on top of
>>    "$commit^1" for the last 20 or so commits in the kernel tree.
>>    The "master" version takes 0.15 second per patch on my Duron
>>    750 with 700MB, while this one does that in 0.06 second.
>>    This also helps the memory pressure because we do not have to
>>    regenerate unchanged trees.  810 minor faults with the patch
>>    vs 2150 minor faults without.
>
> Sorry, but not really.  The patch is wrong and the measurement
> was flawed.

Again, sorry, but there are some more bugs in the cache-tree code that I need to fix and re-measure.

In the meantime, please do not use it on your production repositories. It does not seem to produce corrupt trees, but it creates broken index.aux for no good reason.