git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cvsimport - streamline temp index file creation and avoid creating empty tmpfiles

From
Junio C Hamano <junkio@cox.net>
Date
Jun 24, 2006, 06:59 UTC
Message-ID
<7vk67711kf.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<11511257501323-git-send-email-martin@catalyst.net.nz>
Martin Langhoff <martin@catalyst.net.nz> writes:
Show 11 quoted lines
> On 6/24/06, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>> It seems that git-cvsimport makes a temporary file of size 0, which cannot
>> get mmap()ed, because it has size 0.
>
> This switch to tmpnam() avoids creating the tmpfile in the first place and
> streamlines the code. This handling of tmpfiles is slightly safer, but there
> is an inherent race condition.
>
> ---
> NOTE: (a) I cannot reproduce the problem and (b) this is only lightly tested,
> if trivial.
Thanks both.

I'd take this to "next" after I hear from somebody, most likely Johannes, who had trouble with the code earlier that the problem is fixed.

Previous: Martin LanghoffNext: Johannes Schindelin
Message 3 of 9 in “CVS import broken?”
  1. Johannes SchindelinJun 23, 2006
  2. cvsimport - streamline temp index file creation and avoid creating empty tmpfilesMartin Langhoff, Jun 24, 2006
  3. Junio C HamanoJun 24, 2006
  4. Johannes SchindelinJun 24, 2006
  5. Junio C HamanoJun 24, 2006
  6. Martin LanghoffJun 24, 2006
  7. Junio C HamanoJun 24, 2006
  8. Johannes SchindelinJun 24, 2006
  9. Martin LanghoffJun 24, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.