Re: [PATCH] Colourise git-branch output
- From
Junio C Hamano <junkio@cox.net>
- Date
- Dec 12, 2006, 18:43 UTC
- Message-ID
- <7vk60xuf8h.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <200612121103.31110.andyparkins@gmail.com>
Andy Parkins <andyparkins@gmail.com> writes:
Show 6 quoted lines
>> + "", /* LOCAL (normal) */ >> + "\033[32m", /* CURRENT (green) */ > > In keeping with the "don't use green" idea - can I suggest just bold normal > for the CURRENT? That way there is the most minimal use of colour for the > default git-branch output, but still retaining a visual indicator.
I do not have strong preference either way.
The CURRENT is highlighted with '*' so I think we certainly can lose green and even go vanilla. I only tried to avoid bold because no built-in default coloring currently use it, and in the past I've worked with terminals that do not have enough contrast between normal and bold and for some people that might become an issue.