Re: [PATCH] disable t4016-diff-quote.sh on some filesystems

From: Junio C Hamano <junkio@cox.net>
Date: Feb 20, 2007, 19:47 UTC
Message-ID: <7vk5ycvcg4.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <81b0412b0702200127m231425d6p67d2d67e6d7d9b04@mail.gmail.com>

"Alex Riesen" <raa.lkml@gmail.com> writes:

Show 10 quoted lines

> because the filesystems (most typically FAT and NTFS) do not support
> HT nor LF in filenames.
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
>
> ---
> God help me...
> 
>  t/t4016-diff-quote.sh |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)

Buddha help me.

You are still lacking the "good stuff" in what I'd end up saving in a separate file and applying, which is the attachment part...

Show 8 quoted lines

> From 0edbc6df977e7d954032eaf72720c93b86ab4c0f Mon Sep 17 00:00:00 2001
> From: Alex Riesen <raa.lkml@gmail.com>
> Date: Tue, 20 Feb 2007 10:04:32 +0100
> Subject: [PATCH] disable t4016-diff-quote.sh on some filesystems
>
> ---
>  t/t4016-diff-quote.sh |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)

... but that is a minor detail.  I can survive.

> +if ! test : 2>/dev/null >"$P1" ; then
> +	echo >&2 'Filesystem does not support tabs in names'
> +	test_done
> +fi

I do not understand what this test-colon is doing?  Did you mean

	if ! : >"$P1" 2>&1
        then
		...
	fi

I would have written it like this, to check if it really succeeded creating and also we can remove it.

	: >"$P1" 2>&1 && test -f "$P1" && rm -f "$P1" || {
		...
	}