Re: [PATCH] Allow git-diff exit with codes similar to diff(1)

From: Junio C Hamano <junkio@cox.net>
Date: Mar 14, 2007, 09:36 UTC
Message-ID: <7vk5xkcgkb.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <81b0412b0703140207kf887738od482022497d2a63d@mail.gmail.com>

"Alex Riesen" <raa.lkml@gmail.com> writes:

Show 10 quoted lines

> On 3/14/07, Junio C Hamano <junkio@cox.net> wrote:
>> and people who have been learning from the scripts (we used to
>> have lot more scripts) would have picked up that pattern.
>> That's why I already told you that --exit-status is the right
>> thing to do if we were doing it from scratch, but is a wrong
>> thing to do at this point.  Maybe in a release as big as 1.5.0
>> that we pre-announce a lot of interface changes.
>
> This is something I don't understand: why is a new option
> --exit-code wrong?

Sorry, what I said was very confused (I sent out a correction/clarification didn't I?).

In the ideal world we would sensibly make our diff to report with its exit status. Unfortunately we cannot for the above backward compatibility worries, so a new option is an ugly but necessary workaround.