Re: [PATCH] move template_dir logic to configure script.

From: Junio C Hamano <junkio@cox.net>
Date: May 29, 2007, 06:46 UTC
Message-ID: <7vk5us6sa0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <4658BDB0.9040501@xs4all.nl>

Han-Wen Nienhuys <hanwen@xs4all.nl> writes:

> ---

Could I have at least three lines above the --- marker, please?

 (1) Defend _why_ this is a good change --- I would agree that
     this would make it more flexible, and I suspect that your
     main thrust with this is on some platforms (perhaps
     Windows?) you would want to have template_dir that is
     somewhere away from datarootdir.

 (2) an empty line between (1) and (3)

 (3) Signed-off-by: line.

>  config.mak.in |    2 +-
>  configure.ac  |    6 ++++++
>  2 files changed, 7 insertions(+), 1 deletions(-)