git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix a small memory leak in builtin-add

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 30, 2007, 08:28 UTC
Message-ID
<7vk5p5ngzz.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1193641233-3880-2-git-send-email-tsuna@lrde.epita.fr>
Benoit Sigoure <tsuna@lrde.epita.fr> writes:
Show 10 quoted lines
> prune_directory and fill_directory allocated one byte per pathspec and never
> freed it.
>
> Signed-off-by: Benoit Sigoure <tsuna@lrde.epita.fr>
> ---
> I don't know whether this was intentionnal or not (since it's
> only a matter of having small chunks of memory not being
> reclaimed and I don't think we can enter these functions
> twice, so these are not leaks in the sense that the program
> will consume more and more memory).
I think it was just a slop.  Thanks for catching it.
Previous: Benoit Sigoure
Message 3 of 3 in “core-tutorial: Catch up with current Git”
  1. core-tutorial: Catch up with current GitBenoit Sigoure, Oct 29, 2007
  2. Fix a small memory leak in builtin-addBenoit Sigoure, Oct 29, 2007
  3. Junio C HamanoOct 30, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.