git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-apply --whitespace=fix: fix off by one thinko

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 27, 2008, 19:48 UTC
Message-ID
<7vk5kqtc3e.fsf@gitster.siamese.dyndns.org>

When a patch adds a whitespace followed by end-of-line, the trailing whitespace error was detected correctly but was not fixed, due to misconversion in 42ab241 (builtin-apply.c: do not feed copy_wsfix() leading '+').

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 ws.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ws.c b/ws.c
index 522f646..ba7e834 100644
--- a/ws.c
+++ b/ws.c
@@ -234,7 +234,7 @@ int ws_fix_copy(char *dst, const char *src, int len, unsigned ws_rule, int *erro
 	 * Strip trailing whitespace
 	 */
 	if ((ws_rule & WS_TRAILING_SPACE) &&
-	    (2 < len && isspace(src[len-2]))) {
+	    (2 <= len && isspace(src[len-2]))) {
 		if (src[len - 1] == '\n') {
 			add_nl_to_tail = 1;
 			len--;
-- 
1.5.4.3.339.gad2d1
Message 1 of 1 in “git-apply --whitespace=fix: fix off by one thinko”
  1. git-apply --whitespace=fix: fix off by one thinkoJunio C Hamano, Feb 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.