Re: git commit --interactive creates empty commits

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 14, 2008, 07:01 UTC
Message-ID: <7vk5j0apie.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <slrng059n3.nd8.joerg@alea.gnuu.de>

Jörg Sommer <joerg@alea.gnuu.de> writes:

> is it expected that this test fails?

I think you spotted a bug ;-) -i should only affect the way how you build the index. Unless the user does not ask for --allow-empty this should be prevented, I think.

Show 20 quoted lines

> diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
> index c0288f3..2c21428 100755
> --- a/t/t7501-commit.sh
> +++ b/t/t7501-commit.sh
> @@ -123,6 +123,18 @@ test_expect_success \
>  	"interactive add" \
>  	"echo 7 | git-commit --interactive | grep 'What now'"
>  
> +cat >editor <<\EOF
> +#!/bin/sh
> +echo invalid commit > $1
> +EOF
> +chmod 755 editor
> +
> +test_expect_success \
> +	"interactive fails on empty index" \
> +	"export VISUAL=./editor && 
> +	test_must_fail git commit --interactive < /dev/null &&
> +	unset VISUAL"
> +