Re: bug found (Re: git-fast-export SIGSEGV on solaris + backtrace)

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 3, 2008, 08:30 UTC
Message-ID: <7vk5g32wve.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <486C248E.4060205@gmail.com>

SungHyun Nam <goweol@gmail.com> writes:

Show 7 quoted lines

> And the code says it:
>         for (i = 0; i < idnums.size; ++i) {
>                 deco++;
>                 if (deco && deco->base && deco->base->type == 1) {
>
> The 'deco' should be post-incremented? or
> Checking code should be  (i < idnums.size - 1)?

The variable "deco" is a pointer that walks over a hashtable from its offset 0 to its end, so it can never be NULL (well, the code increments before it tests the variable for NULLness, so it is clear that the test is bogus).

What was I smoking when I applied df6a7ff (builtin-fast-export: Add importing and exporting of revision marks, 2008-06-11), I have to wonder...

Thanks for the fix.