Re: [PATCH 1/3] Fix multi-glob assertion in git-svn

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 8, 2008, 09:41 UTC
Message-ID: <7vk5erete1.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1218184918-9135-1-git-send-email-normalperson@yhbt.net>

Eric Wong <normalperson@yhbt.net> writes:

Show 6 quoted lines

> From: Marcus Griep <marcus@griep.us>
>
> Fixes bad regex match check for multiple globs (would always return
> one glob regardless of actual number).
>
> [ew: fixed a bashism in the test and some minor line-wrapping]

Thanks both.

Show 7 quoted lines

> +test_expect_success 'test disallow multi-globs' '
> ...
> +	cd tmp &&
> +		echo "try try" >> tags/end/src/b/readme &&
> +		poke tags/end/src/b/readme &&
> +		svn commit -m "try to try"
> +		cd .. &&

Do you want to ignore exit code from 'svn commit -m' here?

In any case, I'd want to see "temporarily work in subdirectory" done in a subshell when applicable, so that we won't have to worry about where we are when we later add more tests, like this:

	(
        	cd tmp &&
                echo "try try" >>tags/end/src/b/readme &&
                poke tags/end/src/b/readme &&
                svn commit -m "try to try" &&
	) &&

> +	test_must_fail git-svn fetch three 2> stderr.three &&
> +	cmp expect.three stderr.three

s/cmp/test_cmp/;