git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re* ext3: fix ext3_dx_readdir hash collision handling - Regression

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 24, 2008, 22:35 UTC
Message-ID
<7vk5bx1v1k.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.LFD.2.00.0810241524350.3287@nehalem.linux-foundation.org>
Linus Torvalds <torvalds@linux-foundation.org> writes:
Show 14 quoted lines
> On Fri, 24 Oct 2008, Junio C Hamano wrote:
>>
>> Subject: allow readdir(3) to return the same entry twice
>
> The thing is, this really is a kernel bug. We have even bisected it (and 
> it hasn't hit any released kernel). The original reporter showed it with a 
> simple "rm -r".
>
> So it really isn't a git bug, even though I initially thought it might be, 
> before I looked closer.
>
> That said, the git patch may be worth it just because two *concurrent* 
> invocations of "git clean" could then cause one (or both) to fail this 
> way.

Yeah, or on perhaps a buggy implementation of readdir(3) on somebody else's system. In either case, I just thought it might be a low impact belt-and-suspenders fix that is worth considering.

Previous: Linus Torvalds
Message 3 of 3 in “Re* ext3: fix ext3_dx_readdir hash collision handling - Regression”
  1. Junio C HamanoOct 24, 2008
  2. Linus TorvaldsOct 24, 2008
  3. Junio C HamanoOct 24, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.