git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git show <tree>: show mode and hash, and handle -r

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 31, 2008, 17:37 UTC
Message-ID
<7vk5bo8y3m.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0810311753080.22125@pacific.mpi-cbg.de.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 13 quoted lines
> Hi,
>
> On Thu, 30 Oct 2008, Junio C Hamano wrote:
>
>> I wonder if it would help breaking down cmd_log_init() a bit like this.
>
> Sorry, I am quite busy (this is the first time I am able to check my mail 
> since the GitTogether), so I cannot look at that in detail.
>
> However, I strongly expect your suggestion not to help: for showing 
> commits, we _want_ recursive to be the default.  And switching that on 
> devoids us from being able to DIFF_OPT_TST(.., RECURSIVE) to detect if the 
> user said '-r' _explicitely_.

You can turn on recursive unconditionally for the normal "show committish" case, and check for explicit "-r" for "show treeish" that was bolted-on much later, can't you?

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 6 of 7 in “git show <tree>: show mode and hash, and handle -r”
  1. git show <tree>: show mode and hash, and handle -rJohannes Schindelin, Oct 29, 2008
  2. Johannes SixtOct 29, 2008
  3. Johannes SchindelinOct 29, 2008
  4. Junio C HamanoOct 30, 2008
  5. Johannes SchindelinOct 31, 2008
  6. Junio C HamanoOct 31, 2008
  7. Johannes SchindelinOct 31, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.