Re: [PATCH] fix git format-patch --cc=<email> format

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2009, 02:24 UTC
Message-ID: <7vk57aasjx.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090301010116.GA20255@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 22 quoted lines

> On Sat, Feb 28, 2009 at 09:29:58AM -0800, Junio C Hamano wrote:
>
>> >> If there are multiple --cc=<email> arguments, git format-patch will generate
>> >> patches with cc lines like:
>> >>  Cc: <email>,
>> >>      <email>
>> >> which git send-email fails to parse.
>> >> git send-email only accept formats like:
>> >>  Cc: <email>
>> >>  Cc: <email>
>> >> So change git format-patch to generate patches in a proper format.
>> >
>> > This is fixed in next, but we fixed send-email instead to handle the
>> > messages that format-patch generates, as they should be valid.
>> 
>> Per RFC2822 3.6 (pp 19-20), "cc" is to appear at most once (same is true
>> for "to" and "bcc").  I think fix to format-patch is necessary regardless
>> of what send-email does.
>
> Then isn't the current format-patch output (folding the cc over
> multiple lines) correct, and the patch (outputting multiple cc headers)
> wrong?

Ahh, sorry I misread what the commit message was saying and the patch was doing.