Re: What's cooking in git.git (Jul 2009, #01; Mon, 06)

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 6, 2009, 21:38 UTC
Message-ID: <7vk52l1oht.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200907062229.11763.mcamen@mcamen.de>

Marcus Camen <mcamen@mcamen.de> writes:

Show 20 quoted lines

> On Montag 06 Juli 2009, Junio C Hamano wrote:
>> * ml/http (Wed May 27 23:16:03 2009 -0400) 2 commits
>>  - http.c: add http.sslCertPasswordProtected option
>>  - http.c: prompt for SSL client certificate password
>>
>> I've rewritten these two to (1) move the #ifdef out of the main
>> codepath, and (2) use configuration/environment to make the misfeature
>> of always asking for a passphrase even a key/cert is unencrypted
>> optional.  I tried to be careful but extra sets of eyeballs would be
>> nice to check the result.
>>
>> Nobody seems to be jumping up-and-down asking for this or helping to
>> push this forward.  Perhaps it's time to drop it?
>
> /me jumping up-and-down
>
> This fix is crucial for corporate environments where HTTPS is the only way 
> to access GIT repositories outside the firewall.
>
> I verified the patch and everything works as expected.

Thanks.

What did you exactly mean by "everything"?

 - On a protected key/cert, with configuration, it asks the question once.

 - On an unprotected key/cert, without configuration, it never asks the
   question.

 - On an unprotected key/cert, with configuration, it asks an useless
   question but it does so only once.

You tested all of the above? I am not demanding you to test all of these, but we need to make sure at least somebody did. Especially because it would be a regression if the second one does not.