Re: [PATCH] pull: refuse complete src:dst fetchspec arguments

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 29, 2009, 16:58 UTC
Message-ID: <7vk4w5g1j0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091229200513.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> writes:

> Junio, could you tell us what happened to this thread?
>
> The patch rejects "git pull repo A:B" because it is almost always a mistake;
> I think it makes sense.

It seems that we got sidetracked into a long thread on different (but interesting) side topics. I think what the patch attempts to do is quite sane, and the implementation is very straightforward. Perhaps we should resurrect it, but with a proper "declare deprecation now, first warn then refuse in two releases" steps. I.e. the actual refusal would happen in 1.7.1 or later.

One side topic was Daniel wondering if we should restrict the value of B for "git fetch repo A:B" so that "fetch" is not used to update the refs outside refs/remotes namespace. I personally think it is an unwarranted restriction, and also it is more or less an unrelated issue anyway.

Another side topic that distracted us was about the difference between the autogenerated commit log messages for "git pull origin topic" and "git fetch && git merge origin/topic". I personally think it is very good that the latter already says "Merge remote branch 'origin/topic'" and there is no need to turn that into "Merge 'topic' of ..." (actually I'd prefer it the way it is).