Re: [PATCH 0/5] Speed up string search routines

Fredrik Kuivinen <frekui@gmail.com> writes:

Thanks.

It needs to be a bit more friendly to readers of "git log" and ReleaseNotes by hinting why use of kwset is beneficial (e.g. "use kwset instead of memmem to find fixed string more efficiently") in the commit titles.

The preference of using GPLv2 version was already mentioned by a few people.

Shouldn't obstack.[ch] be in compat/ so that people on platforms where they are natively available do not have to compile our own copies?

It is somewhat curious that you gave numbers for only negative case in pickaxe test and numbers for only positive case in grep test. Does this conversion have some interesting performance charasteristics such as penalizing positive-match case to speed up negative-match case or vice versa (the earlier "grep lookahead" work had that effect, even though the downside was really small)?