git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add `[decorate]' configuration section.

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 25, 2010, 23:12 UTC
Message-ID
<7vk4u0rju2.fsf@alter.siamese.dyndns.org>
In-Reply-To
<alpine.LNX.2.00.1002261131190.19126@vqena.qenxr.bet.am>
Steven Drake <sdrake@xnet.co.nz> writes:
Show 7 quoted lines
>   On Tue, 16 Feb 2010, Junio C Hamano wrote:
>   > I was not worried about what your change does.  I am worried about
>   > protecting what the code after your change currently does from future
>   > changes done by other people while you are not actively watching the
>   > patches in flight on this list.
>
> But that can easly be with the patch below.

What does that buy us? "future changes" can revert your patch to builtin-log.c easily.

I was talking about having tests in the test suite; any "future changes" that breaks the output your series has established would not pass if you specify what the expected output should be there. Of course they can change the test pattern in their patches, but then we will immediately know they are changing the output.

Previous: Steven DrakeNext: Steven Drake
Message 8 of 10 in “Add `[decorate]' configuration section.”
  1. Add `[decorate]' configuration section.Steven Drake, Feb 17, 2010
  2. Junio C HamanoFeb 17, 2010
  3. Re* [PATCH] Add `[decorate]' configuration section.Junio C Hamano, Feb 17, 2010
  4. Heiko VoigtFeb 20, 2010
  5. Thomas RastFeb 20, 2010
  6. Junio C HamanoFeb 22, 2010
  7. Steven DrakeFeb 25, 2010
  8. Junio C HamanoFeb 25, 2010
  9. Steven DrakeFeb 26, 2010
  10. Steven DrakeFeb 26, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.