Re: [PATCH 0/3] Support relative path in <blah>:path syntax
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 17, 2010, 17:54 UTC
- Message-ID
- <7vk4kbg7jz.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1289484484-8632-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
Show 5 quoted lines
> Sorry Jonathan I lied. I did not pick up your fast-import changes. > Could not find how to test it. And it seems fast-import only cares > about commits, not the target audience of this syntax. > > Document is not updated because I think it's intuitive enough.
When you say <tree>:<path>, you would intuitively expect that the path is relative to <tree>, but this patch deliberately breaks (in a good way) that expectation by introducing a magic token "./". Once you know that "./" magic _exists_, it is obvious what it means, but people may not even imagine that such a magic may exist in the first place (certainly old timers won't), and would not know what the magic token is if you do not tell them.
It needs to be documented.