Re: [PATCH] t/annotate-tests: Use echo & cat instead of sed
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 5, 2011, 05:39 UTC
- Message-ID
- <7vk4e5bt90.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1304570617-17603-1-git-send-email-brian@gernhardtsoftware.com>
An earlier patch from Arjen Laarhoven
From: Arjen Laarhoven <arjen@yaph.org> Subject: [PATCH] annotate.sh: Fix failing test on OS X Date: Wed, 4 May 2011 15:36:21 +0200 Message-ID: <1304516181-92364-1-git-send-email-arjen@yaph.org>
seems to attempt to address the same issue but with a twist to deal with an incomplete line at the end of file.
Arjen, does Brian's patch look good to you, too? It is much less tricky and should look obviously correct even to people who sees the code in question for the first time.
Thanks, both.