Re: [PATCH] send-email: add option -h

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 5, 2011, 20:08 UTC
Message-ID: <7vk49mbvlk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110903170612.GA3536@ecki>

Clemens Buchacher <drizzd@aon.at> writes:

Show 7 quoted lines

> Most other git commands print a synopsis when passed -h. Make
> send-email do the same.
>
> Signed-off-by: Clemens Buchacher <drizzd@aon.at>
> ...
> +my $help;
> +my $rc = GetOptions("help|H|h" => \$help,

I do not think what the patch aims to do is wrong per-se, but

 $ git send-email --help

already shows the full documentation, and I find it is misleading to say "help|H|h" here to pretend as if a long-help is triggered with this command. For that matter, do we have any other place that accept -H for help?

IOW, shouldn't this line be this instead?

> +my $rc = GetOptions("h" => \$help,