Re: [PATCH 0/3] use constants for sideband communication channels

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 14, 2011, 04:56 UTC
Message-ID: <7vk45zsqd8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1323800931-37123-1-git-send-email-iheffner@gmail.com>

iheffner@gmail.com writes:

> In order to make more clear how the different channels in sidechannel.c
> are to be used, I'm proposing some macros/constants which can be used in
> place of the "magic numbers" that mean little or nothing to someone not
> familiar with the protocol.

I am not fundamentally opposed to the stated goal, but the posted patches make the resulting code way too wide for comfortable reading. Can we use a bit shorter symbols?

Perhaps a good way to start would be to first refrain from using these symbols, but give a prominent comment near the API functions that are used to send and receive sideband data to explain which band is used for what purpose, which should be enough for people who are writing the code to link with these functions.