git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Make http-backend REMOTE_USER configurable

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 30, 2012, 01:52 UTC
Message-ID
<7vk422q2ho.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120329222632.GC1413@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> On Thu, Mar 29, 2012 at 06:22:30PM -0400, Jeff King wrote:
>
>> I think an even better thing would be for http-backend to leave
>> GIT_COMMITTER_* alone if it exists; that is the usual well-known
>> interface for setting such things. And then you could specify a
>> detailed committer name and email if you want, or leave them blank to
>> pull from $REMOTE_USER as we do now. As it is now, even if you specify
>> GIT_COMMITTER_EMAIL, it gets overwritten with
>> "$REMOTE_USER@http.$REMOTE_ADDR".
>
> That patch would look something like this:

It would regress for somebody who is running the CGI program while exporting these environment variables pointing at himself and relying on the fact that these are canceled by REMOTE_USER/ADDR (perhaps a web-based editor can write into some repository and commits made by that editor takes the ident information from COMMITTER variables, while another part of the webserver takes a push by spawning the http backend???).

Which is very unlikely.

If somebody else comes up with a valid scenario to show why this patch is a bad idea, I'd stand corrected but at the same time I'd be very surprised.

But I think this is the right thing to do, even though it is not related to the issue William wanted to address with his patch.

Care to sign it off?
Previous: Jeff KingNext: William Strecker-Kellogg
Message 5 of 8 in “Make http-backend REMOTE_USER configurable”
  1. Make http-backend REMOTE_USER configurableWilliam Strecker-Kellogg, Mar 29, 2012
  2. Junio C HamanoMar 29, 2012
  3. Jeff KingMar 29, 2012
  4. Jeff KingMar 29, 2012
  5. Junio C HamanoMar 30, 2012
  6. William Strecker-KelloggMar 30, 2012
  7. Jeff KingMar 30, 2012
  8. Junio C HamanoMar 30, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.