Re: [PATCH] Makefile: track TCLTK_PATH as it used to be tracked

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 18, 2012, 17:07 UTC
Message-ID: <7vk3sfguh2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20121218145753.28253.98431.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 11 quoted lines

> A long time ago, gitk used to live at the root of the git.git
> repository. In 62ba514 (Move gitk to its own subdirectory,
> 2007-11-17) it was moved to a subdirectory, but some code used
> to track TCLTK_PATH was left in the main Makefile instead
> of being moved to the new Makefile that was created in gitk-git/.
>
> The code left in the main Makefile in git.git should now have
> been removed because it was found useless.
>
> And this patch puts some code back to track TCLTK_PATH properly
> where it should be.

It is more like "should have been moved to gitk's Makefile back then, but didn't. Make it so.".

Show 16 quoted lines

>
> Note that there is already some code to do that in git-gui.
>
> At the same time this patch creates a .gitignore and also marks
> some targets in the Makefile as PHONY.
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> Hi Paul,
>
> In this thread:
>
> http://thread.gmane.org/gmane.comp.version-control.git/211641
>
> Junio asked me to send you this patch.
> So here it is, for you to apply to your tree.

Paul, just to clarify, I didn't review the contents of the patch; I merely redirected the patch in the right direction, so this still needs to be vetted by you ;-)

Show 5 quoted lines

> ...
> +GIT-TCLTK-VARS: FORCE
> +	@VARS='$(TRACK_TCLTK)'; \
> +		if test x"$$VARS" != x"`cat $@ 2>/dev/null`" ; then \
> +			echo 1>&2 "    * new Tcl/Tk interpreter location"; \

I think in a related patch to the top-level Makefile changes it to lose "1" to read it as "echo >&2" here.