Re: [PATCH] Do not show empty diff in diff-cache uncached.
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 29, 2005, 20:09 UTC
- Message-ID
- <7vis11n69l.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.58.0505291151250.10545@ppc970.osdl.org>
>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:
LT> I'm not sure I like this.
LT> I actually _expect_ that "git-diff-files" will show files that don't match LT> the index, even if they happen to have the exact content that the index LT> points to. It's how I know whether the index is up-to-date or not.
LT> The exact same thing is trye of git-diff-cache. If something isn't LT> up-to-date in the cache, you should show it, since certain operations LT> depend on the cache being updated.
Let me make sure that we are on the same page. I am only talking about '-p' (diff-patch) case in this patch. The code should continue to show the 0{40} SHA1 on the right hand side in diff-raw output. Do you still want to see the header in that case to match the diff-raw exactly?