Re: [PATCH] builtin-push: resurrect parsing of Push: lines
- From
Junio C Hamano <junkio@cox.net>
- Date
- Apr 30, 2006, 22:02 UTC
- Message-ID
- <7viroqyb69.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.63.0604301405150.2026@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> The C'ification of push left these behind.
> +#define MAX_REFSPECS 10 > +static int current_refspec = 0; > +static char *refspecs_[MAX_REFSPECS];
While this fix makes perfect sense, I think MAX_URI set to 16 is reasonable hard limit, but I am not happy about giving hard limit to MAX_REFSPECS -- that's a regression from the shell script one.