Re: [PATCH] Automatically line wrap long commit messages.

From: Junio C Hamano <junkio@cox.net>
Date: May 29, 2006, 09:16 UTC
Message-ID: <7virnp8a30.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060529085738.GB29500@spearce.org>

Shawn Pearce <spearce@spearce.org> writes:

Show 11 quoted lines

> When using -m on the command line with git-commit it is not uncommon
> for a long commit message to be entered without line terminators.
> This creates commit objects whose messages are not readable in
> 'git log' as the line runs off the screen.
>
> So instead reformat log messages if they are supplied on the
> command line.
>
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---
>  This one might cause some problems for people.

I am already moderately negative on multiple -m so in the light of it this one looks totally unneeded. You could do a number of things:

	$ git commit -m 'This is my message.

	This is the first line of the message body.'
        $ cat >L <<EOF
        This is my message.

	This is the first line of the message body.'
	EOF
	$ git commit -F L
	$ fmt <<EOF
        This is my message.

	This is the first line of the message body.'
	EOF
	$ git commit -F L

We probably should allow "commit -F -" to read from the standard input if we already don't, but that is about as far as I am willing to go at this moment.