Re: [PATCH 1/5] git-svn: SVN 1.1.x library compatibility

From: Junio C Hamano <junkio@cox.net>
Date: Jun 28, 2006, 09:02 UTC
Message-ID: <7virml4pqg.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11514623563534-git-send-email-normalperson@yhbt.net>

Eric Wong <normalperson@yhbt.net> writes:

Show 9 quoted lines

> Tested on a plain Ubuntu Hoary installation
> using subversion 1.1.1-2ubuntu3
>
> 1.1.x issues I had to deal with:
>
> * Avoid the noisy command-line client compatibility check if we
>   use the libraries.
>
> * get_log() arguments differ.

Maybe you would want to have a single wrapper sub {} for this, instead of repeating it all over, perhaps like this:

	sub log_get {
        	my ($SVN_LOG, @args) = @_;
        	if ($SVN::CORE::VERSION ge '1.2.0') {
                	splice(@args, 3, 0, 0);
                }
                $SVN_LOG->get_log(@args);
	}

> -if test -n "$GIT_SVN_LC_ALL" && echo $GIT_SVN_LC_ALL | grep -q '\.UTF-8$'
> +if test -n "$GIT_SVN_LC_ALL" && echo $GIT_SVN_LC_ALL |grep '\.UTF-8$' >/dev/null
>  then

Hmph. I tend to do something like this instead of pipeing echo to grep:

	case "$LC_ALL" in
        *.UTF-8)
        	# it is utf-8
                ;;
        *)
        	# otherwise
                ;;
	esac