Re: Why gitweb commitdiff NO diff output ?

From: Junio C Hamano <junkio@cox.net>
Date: Oct 10, 2006, 02:28 UTC
Message-ID: <7viris9a6g.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <7v1wpgapew.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 23 quoted lines

> "Dongsheng Song" <dongsheng.song@gmail.com> writes:
>
>> NO.
>>
>> When I change the repository's owner to gitweb process,  no diff output yet.
>>
>> $ chown -R www-data:www-data  cauchy/ gcc/ mph/
>>
>> 2006/10/10, Junio C Hamano <junkio@cox.net>:
>>> The site does not return any of these four blobs that are part
>>> of the commitdiff when a=blob is requested on them.
>>>
>>>         file:a34d77e47bf1561db1ade4f6b247598b880f80d5 ->
>>>         file:7625c494df01d4745e67bd4423e2fdbe9fc43799
>>>
>>>         file:b207fe30a5430f97d27d398d89c974b068694c7a ->
>>>         file:57b07ace4bb6352416bbf9436b9f2642b3273257
>>>
>>> I would first suspect if the repository actually have them _and_
>>> with an appropriate mode protection to be readable by your
>>> gitweb process.
>
> And does the repository have these four blob objects?

Sorry, the follow-up question was not very helpful to guide another person over e-mail. Let's try again with more specific questions.

What do these say in that repository when run as the webserver user?

	$ for blob in \
          a34d77e47bf1561db1ade4f6b247598b880f80d5 \
	  7625c494df01d4745e67bd4423e2fdbe9fc43799 \
          b207fe30a5430f97d27d398d89c974b068694c7a \
          57b07ace4bb6352416bbf9436b9f2642b3273257
	  do
          	git cat-file -t $blob || echo $blob does not exist
	  done
	$ git cat-file commit c977ee1b2e54d67bb379ce476f784431c32136d7 |
	  grep 'parent '
	$ git diff-tree -p c977ee1b2e54d67bb379ce476f784431c32136d7 | wc

The first one tries to make sure you have those four blob objects in the repository, the second tries to make sure the commit is a single parent commit as your gitweb output suggests, and the last one is to obtain the diff text.

Also do you have the same problem with other commits, or is this the only commit your gitweb is having trouble with showing commitdiff?