Re: [PATCH 1/2] Makefile: add quick-install-doc for installing pre-built manpages

From: Junio C Hamano <junkio@cox.net>
Date: Dec 23, 2006, 07:59 UTC
Message-ID: <7virg3t54l.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11668546833727-git-send-email-normalperson@yhbt.net>

Eric Wong <normalperson@yhbt.net> writes:

> This adds and uses the install-doc-quick.sh file to
> Documentation/, which is usable for people who track either the
> 'html' or 'man' heads in Junio's repository.

Sadly I cannot use this myself ;-).

Two points and a half.

(1) DESTDIR traditionally is always used to denote the virtual
    root directory for fake install, typically later to be
    copied over elsewhere or tarred up (e.g. "install git.1
    $(DESTDIR)/usr/share/man/man1/git.1"); I'd suggest to make
    install-doc-quick.sh script take two parameters, the branch
    and the destination directory.

(2) "git-clone" makes my html and man branches tracked with
    remotes/origin/{html,man} by default; you would want to make
    the local tracking branch 'man' you have hardcoded in the
    Makefile overridable and make it default to "origin/man".

(2.5) "chmod +x install-doc-quick.sh", even if you say "sh
      ./..." in your Makefile.