Re: [PATCH] git-add: allow path limiting with -u

From: Junio C Hamano <junkio@cox.net>
Date: May 14, 2007, 01:29 UTC
Message-ID: <7virawp4zo.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070514004224.GB6689@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> On Sun, May 13, 2007 at 12:35:24PM +0200, Jakub Narebski wrote:
>
>> The fact that "add --interactive does not take any parameters" is
>> separate issue (which, accidentally, was adressed in the same patch).
>
> I don't generally use add --interactive, but I imagine that
> path-limiting would also make sense there. I think it would be a bit
> harder to implement (and test!), since there are many calls to commands
> which would need the limits. So I will leave that unless somebody really
> cares about it.

I do not use -i myself that much, but due to its "interactive" nature, I would imagine that limiting path upfront is actually counter-productive. During the interactive refining process you might notice that you wanted to handle some other paths you excluded from the command line, but you won't be able to access them if you limit upfront. In other words, command line limiter would only interfere with what the interactive user would really want to do.