Re: [PATCH] Makes 'git-stash show' stay quiet when there are no stashes.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 14, 2007, 01:34 UTC
- Message-ID
- <7vir32xdn3.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20071214012838.GA8914@fawkes>
Jing Xue <jingxue@digizenstudio.com> writes:
Show 7 quoted lines
> (I tried to send this trivial patch for a couple of times using > git-send-email, but somehow it never turned up.) > > Currently when there are no stashes, 'git stash show' basically aborts with an > error message from rev-parse: "fatal: Needed a single revision", which can be > confusing. This patch makes git-stash keep quiet and exit gracefully in that > case.
I agree "git stash show" should not give cryptic error message, but I think you should do this only when the user did not explicitly say which stash to show (that is, we should still give error message if the user said "git stash show garbage").