Re: [PATCH 3/3] log/show/whatchanged: introduce format.pretty configuration

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 2, 2008, 17:00 UTC
Message-ID: <7vir05oybp.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1204448753-4471-3-git-send-email-crquan@gmail.com>

Denis Cheng <crquan@gmail.com> writes:

Show 15 quoted lines

> When running log/show/whatchanged from the command line, the user may
> want to use a preferred format without having to pass --pretty=<fmt>
> option every time from the command line.  This teaches these three
> commands to honor a new configuration variable, format.pretty.
>
> The --pretty option given from the command line will override the
> configured format.
>
> The earlier patch fixed the only in-tree caller that runs these
> commands for a purpose other than showing the output directly to the
> end user (the other in-tree caller is "git bisect visualize", whose
> output directly goes to the end user and should be affected by this
> patch).
>
> Signed-off-by: Denis Cheng <crquan@gmail.com>

I see you pretty much copied my suggested commit log messages except that you dropped the warning about the need to adjust out-of-tree scripts by end users from this one. I however think that was the most important part. We need to warn our users fairly aggressively in Release Notes about possible compatibility issues, and commit log messages are one of the most important sources for that.

Incidentally, I noticed only one when I wrote the above but now we have more, so "the only in-tree caller that runs" part is totally bogus.

No need to resend anything, as I can manage with these three messages.

Thanks.