[Junio C Hamano] Re: Consolidate SHA1 object file close

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 14, 2008, 22:42 UTC
Message-ID: <7viqwbfxk6.fsf@gitster.siamese.dyndns.org>

Somehow the thread went off-list, so I'm diverting it back to the list...

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 14 quoted lines

> On Sat, 14 Jun 2008, Junio C Hamano wrote:
>> 
>> I've queued this...
>> 
>> commit 6483925999cde47e5108414ac3f57760394ee2d2
>> Author: Junio C Hamano <gitster@pobox.com>
>> Date:   Fri Jun 13 23:00:51 2008 -0700
>> 
>>     sha1_file.c: dead code removal
>
> Ok, the following three emails will contain three patches on top of that 
> commit that I think are ready for inclusion. They haven't seen a ton of 
> testing, and they are obviously to very core functionality, so in that 
> sense they are a big "scary".

Other than that I had to stop for a few seconds to think at the magic "20 bytes longer", they look scary-but-correct ;-).

I've tagged 1.5.6-rc3 with this (and other fixups), but it appears the network between me and k.org is crappy today so I'll stop hacking for the rest of the afternoon and spend time on something else. Will push the results out sometime tonight.

Thanks.